fix: the onboarding module uses python's hashlib in onboarding.py#5108
Open
orbisai0security wants to merge 1 commit into
Open
fix: the onboarding module uses python's hashlib in onboarding.py#5108orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix high severity security issue in
aider/onboarding.py.Vulnerability
V-001aider/onboarding.py:168Description: The onboarding module uses Python's hashlib.sha256() to hash credentials or API keys at line 168. SHA-256 is a general-purpose cryptographic hash function designed for speed — it is not suitable for password or credential storage. Without per-entry salting, identical credentials produce identical hashes, enabling rainbow table lookups. Without key-stretching (iterative hashing), modern GPUs can compute billions of SHA-256 hashes per second, making offline brute-force attacks trivially fast. This pattern is confirmed in both production code and tests.
Changes
aider/onboarding.pyVerification
Automated security fix by OrbisAI Security