Add OpenPBR support to Viewer#18432
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Reviewer - this PR has made changes to one or more package.json files. |
|
Reviewer - this PR has made changes to the build configuration file. This build will release a new package on npm If that was unintentional please make sure to revert those changes or close this PR. |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18432/merge/index.html#WGZLGJ#4600 Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves): https://playground.babylonjs.com/?snapshot=refs/pull/18432/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/18432/merge#BCU1XR#0 If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools. |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
⚡ Performance Test Results🟢 All performance tests passed — no regressions detected. |
🟢 Memory Leak Test Results13 passed, 0 leaked out of 13 scenarios 🟢 All memory leak tests passed — no leaks detected. Passed Scenarios (13)
|
ryantrem
left a comment
ryantrem
left a comment
There was a problem hiding this comment.
We'll also need to update the Viewer docs and Configurator.
|
@ryantrem, I've updated the configurator but I'm having trouble running it locally to test. I repeatedly get an error about |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU |
⚡ Performance Test Results🟢 All performance tests passed — no regressions detected. |
🟢 Memory Leak Test Results13 passed, 0 leaked out of 13 scenarios 🟢 All memory leak tests passed — no leaks detected. Passed Scenarios (13)
|
|
@MiiBond I pushed a fix for the |
…/Babylon.js into mbond/openpbr-in-viewer
|
Thank you. How do I run the viewer tests in WebGPU? I don't see an option for that. The default model in "Viewer Test App" doesn't load with OpenPBR because it uses the legacy spec-gloss extension for glTF. That is a known issue and I've added spec-gloss support in #18430 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
⚡ Performance Test Results🟢 All performance tests passed — no regressions detected. |
|
Visualization tests for WebGPU |
|
WebGL2 visualization test reporter: |
🟢 Memory Leak Test Results13 passed, 0 leaked out of 13 scenarios 🟢 All memory leak tests passed — no leaks detected. Passed Scenarios (13)
|
|
I believe when you run the tests locally they should be WebGPU by default. I think the errors I was seeing were with the ufo model the test app uses (or it might have been the boombox), but I was only seeing errors with WebGPU, not WebGL. Do we just need to wait for the other PR you mentioned then to verify everything is working correctly with this PR? |
|
The errors with the UFO should be with OpenPBR only, not strictly WebGPU. |
|
Okay, I've merged my changes from master and the WebGPU errors are gone and spec-gloss models also load properly with OpenPBR. So, I think this PR is good now. |
4 participants
This adds support for the useOpenPBR flag. It also adds a material dropdown in the test viewer that triggers a reload of the model. I had to add some tracking for the current model so that it didn't keep reloading the default UFO model. Similarly for the Viewer Configurator.