feat: Add texture repetition breaking for Standard, PBR, and OpenPBR materials by Popov72 · Pull Request #18448 · BabylonJS/Babylon.js

Popov72 · 2026-05-11T20:18:48Z

Summary

Add built-in support for breaking visible texture tiling patterns using 4 techniques, directly in Standard, PBR, and OpenPBR materials.

New API

// Set the mode (ordered by cost)
material.textureRepetitionMode = Constants.TEXTURE_REPETITION_NOISE_BLEND;       // 3 fetches
material.textureRepetitionMode = Constants.TEXTURE_REPETITION_HEX_TILING;        // 3 fetches
material.textureRepetitionMode = Constants.TEXTURE_REPETITION_TILE_RANDOMIZATION; // 4 fetches
material.textureRepetitionMode = Constants.TEXTURE_REPETITION_VORONOI_BOMBING;   // 9 fetches

// Hex tiling has 4 configurable parameters
material.textureRepetitionHexTilingParams = [1.0, 0.6, 7.0, 0.5];
// [rotationStrength, fallOffContrast, exponent, contrast]

Default is TEXTURE_REPETITION_NONE (0) — zero overhead, TEXRD macro compiles to plain texture2D / textureSample.

Techniques

Mode	Fetches	Description
Noise Blend	2	Low-frequency noise-driven offset blending (Inigo Quilez)
Hex Tiling	3	Hex-tile grid with per-tile rotation and luminance-weighted blending (Mikkelsen, JCGT 2022)
Tile Randomization	4	Per-tile random offset and mirror (Inigo Quilez)
Voronoi Bombing	9	Smooth Voronoi with Gaussian-weighted blending (Inigo Quilez)

Implementation

A TEXRD macro in a new shader include replaces texture2D / textureSample calls for all tiling surface textures
When mode is 0 (default), TEXRD compiles to plain texture2D / textureSample — zero cost
Property lives on Material base class, available to all material types
Both GLSL and WGSL supported (WebGL + WebGPU)
Inspector v2 support with mode dropdown and hex tiling parameter sliders

Visualization Tests

3 new tests added, one per material type (Standard, PBR, OpenPBR), each showing 4 ground planes with the 4 repetition modes.

Demo Playground

https://playground.babylonjs.com/#7XUUXW#0

Documentation

Documentation will follow once the PR is merged.

…materials Add built-in support for breaking visible texture tiling patterns using 4 techniques: - Noise Blend (2 texture fetches) - low-frequency noise-driven offset blending - Hex Tiling (3 fetches) - hex-tile grid with per-tile rotation and luminance-weighted blending - Tile Randomization (4 fetches) - per-tile random offset and mirror - Voronoi Bombing (9 fetches) - smooth Voronoi with Gaussian-weighted blending New API: - material.textureRepetitionMode (Constants.TEXTURE_REPETITION_*) - material.textureRepetitionHexTilingParams ([rotStrength, fallOff, exponent, contrast]) Implementation uses a TEXRD macro in shaders that compiles to plain texture2D/textureSample when mode is 0 (default), so there is zero overhead for existing materials. Supports WebGL (GLSL) and WebGPU (WGSL). Inspector v2 support with mode dropdown and hex tiling parameter sliders. 3 visualization tests added (Standard, PBR, OpenPBR). References: - Inigo Quilez: https://iquilezles.org/articles/texturerepetition/ - Morten S. Mikkelsen, JCGT 2022: https://jcgt.org/published/0011/03/05/ Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

bjsplat · 2026-05-11T20:22:22Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

sebavan

Just wondering if this should be a material plugin instead ?

Copilot

Pull request overview

Adds a built-in “texture repetition breaking” feature to Babylon.js materials by routing key texture samples through a new TEXRD shader macro (GLSL + WGSL), exposing a new Material.textureRepetitionMode API (plus hex-tiling params), and wiring it into Inspector v2 and visualization tests.

Changes:

Introduces new GLSL/WGSL shader include(s) implementing multiple texture anti-tiling techniques and switches many material texture samples to TEXRD.
Adds new public Material API + engine Constants.TEXTURE_REPETITION_* values and propagates the mode/params into Standard/PBR/OpenPBR defines + UBOs.
Adds Inspector v2 UI and three new visualization test cases/playgrounds.

Reviewed changes

Copilot reviewed 46 out of 49 changed files in this pull request and generated 12 comments.

Show a summary per file

File	Description
packages/tools/tests/test/visualization/config.json	Adds 3 visualization test entries for Standard/PBR/OpenPBR texture repetition modes.
packages/dev/inspector-v2/src/services/panes/properties/materialPropertiesService.tsx	Registers a new “Texture Repetition” section in the Material properties pane.
packages/dev/inspector-v2/src/components/properties/materials/materialProperties.tsx	Adds mode dropdown + hex-tiling parameter sliders to Inspector v2.
packages/dev/core/src/ShadersWGSL/ShadersInclude/textureRepetitionFunctions.fx	New WGSL implementation of repetition-breaking sampling + `TEXRD` macro.
packages/dev/core/src/ShadersWGSL/ShadersInclude/pbrUboDeclaration.fx	Adds `vTextureRepetitionHexTilingParams` to the PBR WGSL material UBO.
packages/dev/core/src/ShadersWGSL/ShadersInclude/pbrBlockLightmapInit.fx	Routes lightmap sampling through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/ShadersInclude/pbrBlockFinalUnlitComponents.fx	Routes emissive sampling through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrUboDeclaration.fx	Adds `vTextureRepetitionHexTilingParams` to the OpenPBR WGSL material UBO.
packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrTransmissionLayerData.fx	Routes transmission texture reads through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrThinFilmLayerData.fx	Routes thin-film texture reads through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrSubsurfaceLayerData.fx	Routes subsurface texture reads through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrNormalMapFragment.fx	Routes OpenPBR normal map reads through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrFuzzLayerData.fx	Routes fuzz texture reads through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrCoatLayerData.fx	Routes coat texture reads through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrBaseLayerData.fx	Routes base/specular/etc texture reads through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/ShadersInclude/openpbrAmbientOcclusionData.fx	Routes AO texture reads through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/ShadersInclude/defaultUboDeclaration.fx	Adds `vTextureRepetitionHexTilingParams` to the default WGSL material UBO.
packages/dev/core/src/ShadersWGSL/ShadersInclude/bumpFragment.fx	Routes bump map reads through `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/pbr.fragment.fx	Includes `textureRepetitionFunctions` and switches multiple samplings to `TEXRD` (WGSL).
packages/dev/core/src/ShadersWGSL/default.fragment.fx	Includes `textureRepetitionFunctions` and switches multiple samplings to `TEXRD` (WGSL).
packages/dev/core/src/Shaders/ShadersInclude/textureRepetitionFunctions.fx	New GLSL implementation of repetition-breaking sampling + `TEXRD` macro.
packages/dev/core/src/Shaders/ShadersInclude/pbrVertexDeclaration.fx	Adds `vTextureRepetitionHexTilingParams` uniform declaration (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/pbrUboDeclaration.fx	Adds `vTextureRepetitionHexTilingParams` to the PBR GLSL material UBO.
packages/dev/core/src/Shaders/ShadersInclude/pbrBlockLightmapInit.fx	Routes lightmap sampling through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/pbrBlockFinalUnlitComponents.fx	Routes emissive sampling through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/openpbrVertexDeclaration.fx	Adds `vTextureRepetitionHexTilingParams` uniform declaration (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/openpbrUboDeclaration.fx	Adds `vTextureRepetitionHexTilingParams` to the OpenPBR GLSL material UBO.
packages/dev/core/src/Shaders/ShadersInclude/openpbrTransmissionLayerData.fx	Routes transmission texture reads through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/openpbrThinFilmLayerData.fx	Routes thin-film texture reads through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/openpbrSubsurfaceLayerData.fx	Routes subsurface texture reads through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/openpbrNormalMapFragment.fx	Routes OpenPBR normal map reads through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/openpbrFuzzLayerData.fx	Routes fuzz texture reads through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/openpbrCoatLayerData.fx	Routes coat texture reads through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/openpbrBaseLayerData.fx	Routes base/specular/etc texture reads through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/openpbrAmbientOcclusionData.fx	Routes AO texture reads through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/defaultVertexDeclaration.fx	Adds `vTextureRepetitionHexTilingParams` uniform declaration (GLSL).
packages/dev/core/src/Shaders/ShadersInclude/defaultUboDeclaration.fx	Adds `vTextureRepetitionHexTilingParams` to the default GLSL material UBO.
packages/dev/core/src/Shaders/ShadersInclude/bumpFragment.fx	Routes bump map reads through `TEXRD` (GLSL).
packages/dev/core/src/Shaders/pbr.fragment.fx	Includes `textureRepetitionFunctions` and switches multiple samplings to `TEXRD` (GLSL).
packages/dev/core/src/Shaders/openpbr.fragment.fx	Includes `textureRepetitionFunctions` and switches multiple samplings to `TEXRD` (GLSL).
packages/dev/core/src/Shaders/default.fragment.fx	Includes `textureRepetitionFunctions` and switches multiple samplings to `TEXRD` (GLSL).
packages/dev/core/src/Materials/standardMaterial.ts	Adds `TEXTURE_REPETITION_MODE` define + UBO param upload for StandardMaterial.
packages/dev/core/src/Materials/PBR/pbrBaseMaterial.ts	Adds `TEXTURE_REPETITION_MODE` define + UBO param upload for PBRBaseMaterial.
packages/dev/core/src/Materials/PBR/openpbrMaterial.ts	Adds `TEXTURE_REPETITION_MODE` define + UBO param upload for OpenPBRMaterial.
packages/dev/core/src/Materials/material.ts	Introduces `textureRepetitionMode` + `textureRepetitionHexTilingParams` API + serialization.
packages/dev/core/src/Engines/constants.ts	Adds new `Constants.TEXTURE_REPETITION_*` values.

Popov72 · 2026-05-11T20:30:52Z

Just wondering if this should be a material plugin instead ?

It's not possible, we have to patch all texture reads. We can't do that with a material plugin.

- Validate/clamp textureRepetitionMode to 0-4 in setter - Fix Noise Blend to preserve alpha channel (blend vec4, not vec3) - Fix fetch count docs: Noise Blend is 3 fetches, not 2 - Force textureRepetitionMode to 0 on WebGL1 (textureGrad not available) - Add excludedEngines: [webgl1] to visualization tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

bjsplat · 2026-05-11T20:41:28Z

Snapshot stored with reference name:
refs/pull/18448/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/18448/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/18448/merge
https://gui.babylonjs.com/?snapshot=refs/pull/18448/merge
https://nme.babylonjs.com/?snapshot=refs/pull/18448/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/18448/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

bjsplat · 2026-05-11T21:03:07Z

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/18448/merge/

bjsplat · 2026-05-11T21:03:57Z

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/18448/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/18448/merge/?snapshot=refs/pull/18448/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

bjsplat · 2026-05-11T21:04:32Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/interactionplaywright/index.html

bjsplat · 2026-05-11T21:19:03Z

🟢 Memory Leak Test Results

13 passed, 0 leaked out of 13 scenarios

🟢 All memory leak tests passed — no leaks detected.

Passed Scenarios (13)

Scenario	Package
Core Feature Stack	@babylonjs/core
Core Rendering Materials Shadows Stack	@babylonjs/core
Core Textures Render Targets PostProcess Stack	@babylonjs/core
GUI Fullscreen UI Controls	@babylonjs/gui
GUI Mesh ADT Controls	@babylonjs/gui
Loaders Boombox Import	@babylonjs/loaders
Loaders OBJ Direct Load	@babylonjs/loaders
Loaders STL Direct Load	@babylonjs/loaders
Materials Library Stack	@babylonjs/materials
Serializers glTF Export	@babylonjs/serializers
Serializers GLB Export	@babylonjs/serializers
PostProcesses Digital Rain Stack	@babylonjs/post-processes
Procedural Textures Stack	@babylonjs/procedural-textures

bjsplat · 2026-05-11T21:44:08Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/webgl2playwright/index.html

bjsplat · 2026-05-11T21:54:24Z

⚡ Performance Test Results

❌ Failed Tests (4)

Test	Error
Node material 0 [#M5VQE9#41] (webgl2)	�[31mTest timeout of 300000ms exceeded.�[39m
Node material 0 [#M5VQE9#41] (webgpu)	�[31mTest timeout of 300000ms exceeded.�[39m
Node material PBR 1 [#D8AK3Z#121] (webgl2)	�[31mTest timeout of 300000ms exceeded.�[39m
Node material PBR 1 [#D8AK3Z#121] (webgpu)	�[31mTest timeout of 300000ms exceeded.�[39m

…contexts Shared shader includes (bumpFragment, pbrBlockLightmapInit, pbrBlockFinalUnlitComponents) may be included by Node Material or other contexts that don't include textureRepetitionFunctions.fx. Add #ifndef TEXRD fallback to plain texture2D/textureSample in both GLSL and WGSL versions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

bumpFragment.fx, pbrBlockLightmapInit.fx, and pbrBlockFinalUnlitComponents.fx are shared with Node Material which uses regex to replace sampler names. Using TEXRD in these includes breaks NME's regex patterns (e.g. texture.+?bumpSampler). Reverted these shared includes to use plain texture2D/textureSample. TEXRD remains in material-specific shaders (default.fragment.fx, pbr.fragment.fx, openpbr.fragment.fx) and OpenPBR-only includes which are never used by NME. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

bjsplat · 2026-05-11T22:51:52Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

- Restore TEXRD in bumpFragment.fx, pbrBlockLightmapInit.fx, and pbrBlockFinalUnlitComponents.fx (both GLSL and WGSL) so bump, lightmap, and emissive textures benefit from repetition breaking. - Add #ifndef TEXRD fallback guards so NME (which doesn't include textureRepetitionFunctions.fx) still compiles correctly. - Update NME perturbNormalBlock.ts regexes to match both texture2D/ textureSample AND TEXRD patterns using tight alternation: (?:texture2D|TEXRD) for GLSL, (?:textureSample|TEXRD) for WGSL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

bjsplat · 2026-05-11T23:04:55Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

bjsplat · 2026-05-11T23:12:20Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2026-05-11T23:30:56Z

Snapshot stored with reference name:
refs/pull/18448/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/18448/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/18448/merge
https://gui.babylonjs.com/?snapshot=refs/pull/18448/merge
https://nme.babylonjs.com/?snapshot=refs/pull/18448/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/18448/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

bjsplat · 2026-05-11T23:33:04Z

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/18448/merge/

bjsplat · 2026-05-11T23:33:55Z

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/18448/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/18448/merge/?snapshot=refs/pull/18448/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

bjsplat · 2026-05-12T12:07:13Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/webgpuplaywright/index.html

bjsplat · 2026-05-12T12:27:02Z

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/18448/merge/

bjsplat · 2026-05-12T12:28:07Z

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/18448/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/18448/merge/?snapshot=refs/pull/18448/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

bjsplat · 2026-05-12T12:28:57Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/interactionplaywright/index.html

bjsplat · 2026-05-12T12:42:52Z

🟢 Memory Leak Test Results

13 passed, 0 leaked out of 13 scenarios

🟢 All memory leak tests passed — no leaks detected.

Passed Scenarios (13)

Scenario	Package
Core Feature Stack	@babylonjs/core
Core Rendering Materials Shadows Stack	@babylonjs/core
Core Textures Render Targets PostProcess Stack	@babylonjs/core
GUI Fullscreen UI Controls	@babylonjs/gui
GUI Mesh ADT Controls	@babylonjs/gui
Loaders Boombox Import	@babylonjs/loaders
Loaders OBJ Direct Load	@babylonjs/loaders
Loaders STL Direct Load	@babylonjs/loaders
Materials Library Stack	@babylonjs/materials
Serializers glTF Export	@babylonjs/serializers
Serializers GLB Export	@babylonjs/serializers
PostProcesses Digital Rain Stack	@babylonjs/post-processes
Procedural Textures Stack	@babylonjs/procedural-textures

bjsplat · 2026-05-12T12:46:01Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/webgl2playwright/index.html

bjsplat · 2026-05-12T13:00:24Z

⚡ Performance Test Results

🟢 All performance tests passed — no regressions detected.

…ibility The TEXRD fallback was previously declared in shared includes that get inlined inside main() (bumpFragment.fx, pbrBlockLightmapInit.fx, pbrBlockFinalUnlitComponents.fx). WGSL doesn't allow nested function declarations, so a fallback fn TEXRD inside main() failed to compile when these includes were used by NME (which inlines them inside its generated function). Moved the fallback to module-scope includes that NME always emits at top level: bumpFragmentMainFunctions.fx for bump, pbrHelperFunctions.fx for PBR. Added #define TEXRD_DEFINED inside the fallback so the textureRepetitionFunctions include doesn't double-define when both are emitted. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

bjsplat · 2026-05-13T13:20:17Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/webgpuplaywright/index.html

bjsplat · 2026-05-13T13:39:40Z

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/18448/merge/

bjsplat · 2026-05-13T13:40:08Z

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/18448/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/18448/merge/?snapshot=refs/pull/18448/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

bjsplat · 2026-05-13T13:46:21Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/interactionplaywright/index.html

bjsplat · 2026-05-13T13:55:43Z

🟢 Memory Leak Test Results

13 passed, 0 leaked out of 13 scenarios

🟢 All memory leak tests passed — no leaks detected.

Passed Scenarios (13)

Scenario	Package
Core Feature Stack	@babylonjs/core
Core Rendering Materials Shadows Stack	@babylonjs/core
Core Textures Render Targets PostProcess Stack	@babylonjs/core
GUI Fullscreen UI Controls	@babylonjs/gui
GUI Mesh ADT Controls	@babylonjs/gui
Loaders Boombox Import	@babylonjs/loaders
Loaders OBJ Direct Load	@babylonjs/loaders
Loaders STL Direct Load	@babylonjs/loaders
Materials Library Stack	@babylonjs/materials
Serializers glTF Export	@babylonjs/serializers
Serializers GLB Export	@babylonjs/serializers
PostProcesses Digital Rain Stack	@babylonjs/post-processes
Procedural Textures Stack	@babylonjs/procedural-textures

bjsplat · 2026-05-13T14:01:45Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/webgl2playwright/index.html

bjsplat · 2026-05-13T14:01:51Z

⚡ Performance Test Results

🟢 All performance tests passed — no regressions detected.

…pers The fallback TEXRD definitions in pbrHelperFunctions.fx and bumpFragmentMainFunctions.fx now set TEXRD_DEFINED. To prevent the shader's textureRepetitionFunctions include from then re-defining TEXRD (GLSL: 'macro redefined' error), reorder includes so that textureRepetitionFunctions runs FIRST in default/pbr/openpbr fragment shaders. The fallback in helpers then sees TEXRD_DEFINED and skips. Also added missing #include<textureRepetitionFunctions> to ShadersWGSL/openpbr.fragment.fx (it was only present in the GLSL version). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…WGSL OpenPBR shaders WGSL doesn't have function overloading like GLSL. The openpbr WGSL shaders were calling toLinearSpace(vec3) which expects f32, causing 'type mismatch' errors at WGSL compile time. Replaced with toLinearSpaceVec3 in: - openpbrBaseLayerData.fx (base color, specular color) - openpbrCoatLayerData.fx - openpbrFuzzLayerData.fx - openpbrTransmissionLayerData.fx - openpbrIblFunctions.fx (3 sites) - openpbr.fragment.fx (emission) This is independent of the texture repetition feature but was exposed when running OpenPBR scenes through WebGPU. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

bjsplat · 2026-05-13T15:04:15Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2026-05-13T15:23:46Z

Snapshot stored with reference name:
refs/pull/18448/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/index.html#WGZLGJ#4600

Links to test your changes to core in the published versions of the Babylon tools (does not contain changes you made to the tools themselves):

https://playground.babylonjs.com/?snapshot=refs/pull/18448/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/18448/merge
https://gui.babylonjs.com/?snapshot=refs/pull/18448/merge
https://nme.babylonjs.com/?snapshot=refs/pull/18448/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/18448/merge#BCU1XR#0

If you made changes to the sandbox or playground in this PR, additional comments will be generated soon containing links to the dev versions of those tools.

bjsplat · 2026-05-13T15:27:17Z

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/18448/merge/

bjsplat · 2026-05-13T15:31:26Z

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/18448/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/18448/merge/?snapshot=refs/pull/18448/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

bjsplat · 2026-05-13T15:33:53Z

Interaction tests

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/interactionplaywright/index.html

bjsplat · 2026-05-13T15:41:38Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/webgl2playwright/index.html

bjsplat · 2026-05-13T15:42:38Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/18448/merge/testResults/webgpuplaywright/index.html

bjsplat · 2026-05-13T15:44:53Z

🟢 Memory Leak Test Results

13 passed, 0 leaked out of 13 scenarios

🟢 All memory leak tests passed — no leaks detected.

Passed Scenarios (13)

Scenario	Package
Core Feature Stack	@babylonjs/core
Core Rendering Materials Shadows Stack	@babylonjs/core
Core Textures Render Targets PostProcess Stack	@babylonjs/core
GUI Fullscreen UI Controls	@babylonjs/gui
GUI Mesh ADT Controls	@babylonjs/gui
Loaders Boombox Import	@babylonjs/loaders
Loaders OBJ Direct Load	@babylonjs/loaders
Loaders STL Direct Load	@babylonjs/loaders
Materials Library Stack	@babylonjs/materials
Serializers glTF Export	@babylonjs/serializers
Serializers GLB Export	@babylonjs/serializers
PostProcesses Digital Rain Stack	@babylonjs/post-processes
Procedural Textures Stack	@babylonjs/procedural-textures

bjsplat · 2026-05-13T15:55:25Z

⚡ Performance Test Results

🟢 All performance tests passed — no regressions detected.

Copilot AI review requested due to automatic review settings May 11, 2026 20:18

Copilot started reviewing on behalf of Popov72 May 11, 2026 20:19 View session

Popov72 added materials new feature texture labels May 11, 2026

sebavan approved these changes May 11, 2026

View reviewed changes

sebavan requested changes May 11, 2026

View reviewed changes

Copilot AI reviewed May 11, 2026

View reviewed changes

sebavan approved these changes May 11, 2026

View reviewed changes

Popov72 and others added 2 commits May 12, 2026 00:35

style: format perturbNormalBlock.ts

873fb83

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

fix: increase errorRatio to 7.5 for PBR/OpenPBR texture repetition tests

2ba9fb6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Popov72 and others added 2 commits May 13, 2026 16:57

sebavan enabled auto-merge (squash) May 13, 2026 15:12

sebavan merged commit a4f886c into BabylonJS:master May 13, 2026
20 of 23 checks passed

Popov72 mentioned this pull request May 13, 2026

docs: add Texture Repetition Breaking page BabylonJS/Documentation#1576

Open

Conversation

Popov72 commented May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

New API

Techniques

Implementation

Visualization Tests

Demo Playground

Documentation

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

sebavan left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Popov72 commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

🟢 Memory Leak Test Results

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

⚡ Performance Test Results

❌ Failed Tests (4)

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 11, 2026

Uh oh!

bjsplat commented May 12, 2026

Uh oh!

bjsplat commented May 12, 2026

Uh oh!

bjsplat commented May 12, 2026

Uh oh!

bjsplat commented May 12, 2026

Uh oh!

bjsplat commented May 12, 2026

🟢 Memory Leak Test Results

Uh oh!

bjsplat commented May 12, 2026

Uh oh!

bjsplat commented May 12, 2026

⚡ Performance Test Results

Uh oh!

bjsplat commented May 13, 2026

Uh oh!

Popov72 commented May 11, 2026 •

edited

Loading