ci: Add package pre-publish check#1893
Open
vdusek wants to merge 3 commits into
Open
Conversation
vdusek
added
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1893 +/- ##
==========================================
- Coverage 92.82% 92.81% -0.01%
==========================================
Files 167 167
Lines 11699 11699
==========================================
- Hits 10860 10859 -1
- Misses 839 840 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Guards against shipping a wheel or sdist that builds but crashes when installed - the silent failure mode behind PR #1890 - by adding a verification script and wiring it into PR CI and the release workflows as a pre-publish gate. Checks artifact contents, fresh-venv install of both wheel and sdist, core imports, and `crawlee create` scaffolding.
vdusek
force-pushed
the
ci/verify-built-package
branch
from
d3b1195 to
5b35186
Compare
vdusek
changed the title
Replaces the local verify_built_package.py script with the new apify/workflows/python-package-check composite action, so all four Python repos share the same verification logic instead of each maintaining their own copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an end-to-end check that the built sdist and wheel install cleanly, expose the expected sources and data files (
py.typed,project_template/**,_redis/lua_scripts/*.lua), and pass an import +crawlee createsmoke test — guarding against the silent failure mode behind #1890.Wired into every PR via a new reusable
_check_package.yaml, and into both stable and beta release workflows so the exact artifact about to hit PyPI is verified first.