Skip to content

scripts: fix SC2268 shellcheck warning in test_lib.sh#21711

Merged
serathius merged 1 commit into
etcd-io:mainfrom
robin-vidal:fix/sc2268-shellcheck-test-lib
May 13, 2026
Merged

scripts: fix SC2268 shellcheck warning in test_lib.sh#21711
serathius merged 1 commit into
etcd-io:mainfrom
robin-vidal:fix/sc2268-shellcheck-test-lib

Conversation

@robin-vidal
Copy link
Copy Markdown
Contributor

Remove x-prefix pattern in comparison that is no longer needed in modern shells as per shellcheck SC2268.

Fixes #21710

Remove x-prefix pattern in comparison that is no longer needed
in modern shells as per shellcheck SC2268.

Fixes etcd-io#21710

Signed-off-by: robin-vidal <robin.vidal.pro@gmail.com>
@k8s-ci-robot
Copy link
Copy Markdown

Hi @robin-vidal. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@henrybear327
Copy link
Copy Markdown
Contributor

/ok-to-test

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.24%. Comparing base (b2a2cbb) to head (5874f81).
⚠️ Report is 35 commits behind head on main.

Additional details and impacted files

see 33 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21711      +/-   ##
==========================================
- Coverage   70.28%   70.24%   -0.05%     
==========================================
  Files         425      426       +1     
  Lines       35145    35200      +55     
==========================================
+ Hits        24703    24727      +24     
- Misses       9047     9085      +38     
+ Partials     1395     1388       -7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a2cbb...5874f81. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @robin-vidal.

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, robin-vidal, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 053fc70 into etcd-io:main May 13, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

scripts: fix SC2268 shellcheck warning in test_lib.sh

5 participants