Skip to content

Remove special status from "rootValue"#3039

Draft
benjaie wants to merge 3 commits into
graphile:mainfrom
benjaie:rootValue-unspecial
Draft

Remove special status from "rootValue"#3039
benjaie wants to merge 3 commits into
graphile:mainfrom
benjaie:rootValue-unspecial

Conversation

@benjaie
Copy link
Copy Markdown
Contributor

@benjaie benjaie commented Apr 29, 2026

Description

Prior to this rootValue was required to be a mutable object so we could write to it. We would automatically coerce an undefined rootValue to an object to make this the case. However, this means that any resolver wrappers that people are using source == null on to detect root selection set will fail. So we should remove this to improve compatibility with traditional GraphQL resolvers.

Performance impact

Minimal.

Security impact

None known.

Checklist

Internal refactor.

@github-project-automation github-project-automation Bot moved this to 🌳 Triage in V5.0.0 Apr 29, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 29, 2026

⚠️ No Changeset found

Latest commit: 4bf606b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benjaie benjaie marked this pull request as draft April 29, 2026 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🌳 Triage

Development

Successfully merging this pull request may close these issues.

1 participant