chore: remove orphaned deploy_csapi_app_service module and regenerate main.json with latest Bicep#376
Open
Saswato-Microsoft wants to merge 8 commits into
Conversation
- Remove orphaned deploy_csapi_app_service.bicep (never referenced from main.bicep) - Add comment to main.bicep explaining ACR is provisioned separately via docker-build scripts - Remove dead app settings DUMMY_TEST and DISPLAY_CHART_DEFAULT from both Python and C# backend blocks - Add documentation comments to Storage Account in deploy_ai_foundry.bicep explaining AI Foundry platform dependency Resolves: AB#41957 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…cy in Bicep files Co-authored-by: Copilot <copilot@github.com>
Saswato-Microsoft
changed the title
…aned-bicep-dead-settings # Conflicts: # infra/deploy_csapi_app_service.bicep # infra/main.json
Saswato-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
brittneek,
dgp10801,
malrose07,
nchandhi and
toherman-msft
as code owners
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…RT_DEFAULT to CSAPI module
Saswato-Microsoft
changed the title
Saswato-Microsoft
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request removes the
infra/deploy_csapi_app_service.bicepfile, which previously defined the deployment of a CSAPI App Service and its related Azure resources. Additionally, it updates the generatedinfra/main.jsontemplate to reflect the removal and changes the Bicep compiler version used for template generation.Key changes:
Infrastructure as Code Cleanup:
deploy_csapi_app_service.bicepfile, eliminating the Bicep template that defined parameters, resources, and outputs for deploying the CSAPI App Service, Key Vault, App Insights, and related secrets and permissions.Generated Template Updates:
infra/main.jsonfile to use Bicep compiler version0.43.1.21952(was0.42.1.51946) and regenerated template hashes throughout, reflecting the removal of the Bicep file and ensuring consistency with the current infrastructure state. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23]Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information