Bugfix 21816 - PIM privileged role assignment check should account for JIT access into role-assignable groups#1208
Draft
ashwinikarke wants to merge 4 commits into
Draft
Bugfix 21816 - PIM privileged role assignment check should account for JIT access into role-assignable groups#1208ashwinikarke wants to merge 4 commits into
ashwinikarke wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates assessment 21816 to better handle privileged role assignments granted via role-assignable groups by detecting whether those groups use PIM for Groups (JIT/eligible membership) and adjusting how “non-PIM” and “permanent GA” findings are calculated.
Changes:
- Add PIM-for-Groups eligibility schedule checks when privileged role members (and GA members) are groups, to avoid flagging JIT-managed group-based access as non-PIM.
- Adjust the Global Administrator “permanent assignment” expansion logic to only enumerate group members when the group is not JIT-managed via PIM for Groups.
- Refine result messaging and simplify
CustomStatusassignment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+150
to
172
| if ($pimForGroupsSchedules) { | ||
| # Group enforces JIT via PIM for Groups - exclude from PermanentGAGroupList, do not add members | ||
| $permanentGAGroupList = $permanentGAGroupList | Where-Object { $_.id -ne $member.id } | ||
| Write-PSFMessage "Group $($member.displayName) uses PIM for Groups, excluding from permanent GA list" -Level Verbose | ||
| } else { | ||
| # Group does not use PIM for Groups - get members and add to permanentGAUserList (Q5) | ||
| $groupMembers = Invoke-ZtGraphRequest -RelativeUri "groups/$($member.id)/members" -Select 'userPrincipalName,displayName,id,onPremisesSyncEnabled' -ApiVersion beta | ||
| foreach ($groupMember in $groupMembers) { | ||
| # Only process users, skip service principals | ||
| if ($groupMember.'@odata.type' -eq '#microsoft.graph.user') { | ||
| $groupMemberInfo = [PSCustomObject]@{ | ||
| displayName = $groupMember.displayName | ||
| userPrincipalName = $groupMember.userPrincipalName | ||
| id = $groupMember.id | ||
| roleTemplateId = $globalAdminRoleId | ||
| roleDefinitionId = $gaDirectoryRole.id | ||
| roleName = 'Global Administrator (via group)' | ||
| isPrivileged = $true | ||
| assignmentType = 'Via Group' | ||
| onPremisesSyncEnabled = $groupMember.onPremisesSyncEnabled | ||
| } | ||
| $permanentGAUserList += $groupMemberInfo | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.