Skip to content

refactor(skills): compact core Prowler contracts#11089

Open
Alan-TheGentleman wants to merge 1 commit into
refactor/skill-style-core-genericfrom
refactor/skill-style-core-prowler
Open

refactor(skills): compact core Prowler contracts#11089
Alan-TheGentleman wants to merge 1 commit into
refactor/skill-style-core-genericfrom
refactor/skill-style-core-prowler

Conversation

@Alan-TheGentleman
Copy link
Copy Markdown
Contributor

@Alan-TheGentleman Alan-TheGentleman commented May 8, 2026

Context

This is PR 3 of a chained feature-branch refactor to standardize repository skills around a clearer runtime format.

This batch applies the base contract to the core Prowler skills so repo-specific guidance is easier to route, execute, and review.

Description

  • Refactors the core Prowler workflow skills into compact runtime contracts
  • Standardizes prowler, prowler-api, prowler-ui, jsonapi, and django-drf around the same contract shape
  • Makes companion-skill handoff explicit for API, UI, and JSON:API work

Chain Context

feat/skill-style-guide-refactor
└── refactor/skill-style-meta-foundation
    └── refactor/skill-style-core-generic
        └── refactor/skill-style-core-prowler 📍
            └── refactor/skill-style-specialists

Out of scope for this PR:

  • The oversized specialist skills in the final batch (prowler-compliance, django-migration-psql, postgresql-indexing, prowler-attack-paths-query)

Steps to review

  1. Review the updated router and core implementation skills:
    • skills/prowler/SKILL.md
    • skills/prowler-api/SKILL.md
    • skills/prowler-ui/SKILL.md
    • skills/jsonapi/SKILL.md
    • skills/django-drf/SKILL.md
  2. Confirm the five files now follow the shared top-level contract shape
  3. Spot-check that prowler-api and django-drf clearly divide repo-specific constraints from generic DRF guidance
  4. Spot-check that jsonapi is now contract-first and local-reference only

Validation performed:

  • Structural RED/GREEN validation for trigger-first descriptions, exact section order, and local-only references
  • skill-sync intentionally skipped because no metadata-driven surfaces changed

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? No
    • If so, do we need to update permissions for the provider? Please review this carefully.

UI

  • All issue/task requirements work as expected on the UI
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • All issue/task requirements work as expected on the API
  • Endpoint response output (if applicable)
  • EXPLAIN ANALYZE output for new/modified queries or indexes (if applicable)
  • Performance test results (if applicable)
  • Any other relevant evidence of the implementation (if applicable)
  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, Poetry, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

- reshape core Prowler workflow skills into runtime contracts
- standardize companion-skill guidance and decision gates
- trim handbook prose in favor of local operational references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant