fix(ui): preserve scans provider wizard flow#11136
Open
Alan-TheGentleman wants to merge 3 commits into
Open
Conversation
- Keep provider wizard state mounted across scans data refreshes - Add regression coverage for first-provider onboarding flow
Alan-TheGentleman
added
bug
no-changelog
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
Alan-TheGentleman
removed
the
no-changelog
- Document the Launch Scan first-provider wizard fix
Contributor
|
✅ All necessary |
Contributor
🔒 Container Security ScanImage: 📊 Vulnerability Summary
2 package(s) affected
|
Make onOpenWizard required on NoProvidersAdded and drop the unused
internal state/modal fallback. Lift the launch-form provider shape into
ui/types/scans.ts as ScanProviderInfo and reuse it in
scans-launch-section, launch-scan-workflow-form and select-scan-provider
(rename the existing result-shape type to ScanResultProviderInfo to free
the name). Require hasManageScansPermission and thereIsNoProvidersConnected
on ScansLaunchSection and coerce both inputs at the page call site so
undefined fails closed. Simplify the wizard-survives-rerender test to
getByRole("dialog").
alejandrobailo
requested changes
May 13, 2026
Contributor
alejandrobailo
left a comment
alejandrobailo
left a comment
There was a problem hiding this comment.
LGTM, however it belongs to 26.2 as a fix, with backport.
Contributor
Author
|
@alejandrobailo it will be released with the 27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Screen.Recording.2026-05-12.at.14.19.43.mov
The
/scansfirst-provider onboarding flow was reset after creating a provider from Launch Scan → Get Started. The page refreshed with providers data and unmounted the local modal state before users could continue through the wizard.Description
ScansLaunchSectionclient boundary to own the provider wizard modal state across/scansserver refreshes.NoProvidersAddedstandalone behavior while allowing/scansto control modal opening from a stable parent.Steps to review
/scanswith no configured providers./scanspage.Validation performed:
pnpm test:run scans-launch-section.test.tsx/Users/alanbuscaglia/Desktop/Screen Recording 2026-05-12 at 14.19.43.movChecklist
Community Checklist
SDK/CLI
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.