Conversation
mustansir14
reviewed
May 7, 2026
| }() | ||
|
|
||
| bodyString := string(bodyBytes) | ||
| if !(res.StatusCode == http.StatusOK) { |
mustansir14
reviewed
May 7, 2026
mustansir14
approved these changes
May 7, 2026
Contributor
mustansir14
left a comment
mustansir14
left a comment
There was a problem hiding this comment.
Reviewing 800 files was a bit too much.... but I love how this makes the codebase super tidy! Thanks
amanfcp
added
the
review/product-eng
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Medium Risk
Touches a large number of analyzers/detectors with mostly mechanical error-handling and style changes, but includes a few small logic tweaks (e.g., Postgres DB privilege filtering and AWS session token heuristics) that could affect detection/analysis behavior.
Overview
Enables
errcheckandstaticcheckin CI by removing the workflow’s explicit disables, and then resolves the resulting findings across the repo.Most changes are mechanical: consistently ignoring non-critical return values (e.g.,
Close(),RemoveAll(),Setenv()), switching tostrings.ReplaceAll, and small refactors toswitchstatements / error message casing.Includes a couple behavior changes worth review: fixes Postgres database name collection to use the correct connect privilege field, adjusts AWS session token validation logic, and updates HTML decoder tests to reflect
DecodableChunk’s embeddedChunk(got.Datavsgot.Chunk.Data).Reviewed by Cursor Bugbot for commit 9c539b6. Bugbot is set up for automated code reviews on this repo. Configure here.