Allow : and - in Azure App Config Id (#4955)#4956
Open
mjwrona wants to merge 1 commit into
Open
Conversation
Azure-issued App Configuration connection strings encode `Id` as `<prefix>:<base64>`, where the prefix typically contains hyphens. The previous character class accepted only the base64 alphabet, so every real key was silently dropped. Extend the class to include `:` and `-`, and add a test covering the canonical shape. Signed-off-by: Martin Wrona <martin.wrona@digitecgalaxus.ch>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Azure-issued App Configuration connection strings encode
Idas<prefix>:<base64>, where the prefix typically contains hyphens. The previous character class accepted only the base64 alphabet, so every real key was silently dropped. Extend the class to include:and-, and add a test covering the canonical shape.Closes #4955
Checklist:
make test-community)?make lintthis requires golangci-lint)?Note
Low Risk
Low risk: only broadens the Azure App Config connection-string regex and adds test coverage, with no changes to verification or network behavior.
Overview
Updates the Azure App Configuration connection-string detector to accept canonical
Idvalues containing-and:(e.g.<prefix>:<base64>), preventing valid keys from being missed.Adds a unit test covering this canonical
Idshape to ensure the updated regex matches real-world connection strings.Reviewed by Cursor Bugbot for commit 8d054fa. Bugbot is set up for automated code reviews on this repo. Configure here.