cpu: aarch64: add f16 and bf16 support to jit_io_helper and jit_uni_binary#5092
Open
Sqvid wants to merge 2 commits into
Open
cpu: aarch64: add f16 and bf16 support to jit_io_helper and jit_uni_binary#5092Sqvid wants to merge 2 commits into
Sqvid wants to merge 2 commits into
Conversation
1ee6669 to
b77feda
Compare
Signed-off-by: Siddhartha Menon <siddhartha.menon@arm.com>
Signed-off-by: Siddhartha Menon <siddhartha.menon@arm.com>
b77feda to
a9b1bf0
Compare
jondea
reviewed
May 8, 2026
| return; | ||
| } | ||
|
|
||
| host_->str(host_->z31, |
Contributor
There was a problem hiding this comment.
How do we know we can always use z31? Also, I think a comment explaining that this is a fallback would be useful.
jondea
reviewed
May 8, 2026
| } | ||
| case data_type::bf16: { | ||
| if (dst_vmm.getIdx() != src_vmm.getIdx()) | ||
| host_->mov(dst_vmm.s, host_->P_ALL_ONE / Xbyak_aarch64::T_m, |
Contributor
There was a problem hiding this comment.
Can we get rid of this mov with
host_->lsl(dst_vmm.s, src_vmm.s, 16);
If not, a comment explaining why would be useful
jondea
requested changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
f16andbf16support tojit_io_helper_t. I have also demonstrated the impact of these changes by adding support for these data-types tojit_uni_binary_t.Checklist
General
make testandmake test_benchdnn_*) pass locally for each commit?