Add retry mechanism for execPodStep failures#332
Open
l1l1l1l wants to merge 2 commits into
Open
Conversation
Implement retry logic for execPodStep on 404 errors.This will reduce the occurrence of "Error: TypeError: Converting circular structure to JSON"(#2056) on a jittering k8s internal network.
Add retry mechanism for execPodStep failures
Author
|
Related to JSON Converting Problem |
| JOB_CONTAINER_NAME | ||
| ).catch((e: any) => { | ||
| const msg = String(e?.message || e) | ||
| const is404 = |
Collaborator
There was a problem hiding this comment.
Hey, I think this check must be taken from the exception if possible. 404 substring is not enough to confidently say this is 404 error just because the error contains the 404 string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement retry logic for execPodStep on 404 errors.This will reduce the occurrence of "Error: TypeError: Converting circular structure to JSON"(#2056)
on a jittering k8s internal network.