Skip to content

Add retry mechanism for execPodStep failures #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
l1l1l1l wants to merge 2 commits into
base: main
Choose a base branch
from
+28 −6
Open

Add retry mechanism for execPodStep failures #332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
894f9dd
Add retry mechanism for execPodStep failures
l1l1l1l Mar 26, 2026
0bb2548
Merge pull request #1 from l1l1l1l/l1l1l1l-patch-1
l1l1l1l Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions packages/k8s/src/hooks/run-script-step.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,35 @@ export async function runScriptStep(
args.entryPoint = 'sh'
args.entryPointArgs = ['-e', containerPath]
try {
await execPodStep(
[args.entryPoint, ...args.entryPointArgs],
state.jobPod,
JOB_CONTAINER_NAME
)
await (async function () {
const retries = 3
const delayMs = 5000

function attempt(n: number): Promise<void> {
return execPodStep(
[args.entryPoint, ...args.entryPointArgs],
state.jobPod,
JOB_CONTAINER_NAME
).catch((e: any) => {
const msg = String(e?.message || e)
const is404 =
Copy link
Copy Markdown
Collaborator

@nikola-jokic nikola-jokic May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, I think this check must be taken from the exception if possible. 404 substring is not enough to confidently say this is 404 error just because the error contains the 404 string

msg.indexOf('404') !== -1 ||
msg.indexOf('Unexpected server response') !== -1

if (is404 && n > 1) {
core.debug('execPodStep got 404, retrying...')
return new Promise<void>(r => setTimeout(r, delayMs)).then(() =>
attempt(n - 1)
)
}
throw e
})
}

return attempt(retries)
})()
} catch (err) {
core.debug(`execPodStep failed: ${JSON.stringify(err)}`)
core.debug(`execPodStep failed: ${(err as any)?.message || String(err)}`)
const message = (err as any)?.response?.body?.message || err
throw new Error(`failed to run script step: ${message}`)
} finally {
Expand Down